handling agent memory leak #166
Open
+63
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojarjur
reviewed
Jan 23, 2026
Collaborator
ojarjur
left a comment
ojarjur
left a comment
There was a problem hiding this comment.
Thanks for the fix!
There are some formatting issues that need to be addressed, but also please update the PR description to give background on what the issue is (connections leaking of the close message gets dropped) and how this PR addresses it.
Thanks!
| // | ||
| // The returned error value is non-nill if the connection has been closed. | ||
| func (conn *Connection) SendClientMessage(msg interface{}, injectionEnabled bool, injectedHeaders map[string]string) error { | ||
| conn.updateActivity() |
Collaborator
There was a problem hiding this comment.
The formatting for this line and the one below (on line 267) is wrong.
Please run gofmt over the changed files.
|
|
||
| return &message{Type: msg.Type, Data: newMsgBytes}, nil | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Don't delete the trailing newline.
| mux.Handle("/", wrapped) | ||
| return mux, nil | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Also, here, don't delete the trailing newline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.